I don't quite understand it myself. I prefer inserting references and #if conditional logic. But since it's in there... maybe we should make it work. It's not hard.
WILL ----- Original Message ----- From: "Geir Magnusson Jr" <[EMAIL PROTECTED]> To: "Velocity Developers List" <[EMAIL PROTECTED]> Sent: Monday, April 05, 2004 6:36 PM Subject: Re: #stop will be fixed? On Apr 5, 2004, at 3:59 PM, Will Glass-Husain wrote: >> But looks like ASTStop (org.apache.velocity.runtime.parser.node) >> is missing. > > oops. Look like I left it out of the upload. I don't have it any > more, > either. It was pretty basic, though. > Let me put a new patch together in the next few days. > I'd really like to chuck #stop, but I guess people want it? geir > WILL > > > ----- Original Message ----- > From: "Luis Antonio Castro Henriques" <[EMAIL PROTECTED]> > To: "Velocity Developers List" <[EMAIL PROTECTED]> > Sent: Monday, April 05, 2004 11:45 AM > Subject: Re: #stop will be fixed? > > >> >> The patch needed heavy editing to apply. Maybe I have done something >> wrong, But looks like ASTStop >> (org.apache.velocity.runtime.parser.node) >> is missing. I�ve tryed to generate it with javacc, but it appears to >> only generate boilerplate code. I�ve never used javacc before, so I >> can�t say for sure. >> >>> The patch might be out of date. I wrote it against CVS head at the > time, >>> but there may have been a few changes since. It worked for me at the > time >>> (I think I wrote some test code). >>> >>> Can't comment on the timing; that's up to the committer. >>> >>> WILL >>> >>> ----- Original Message ----- >>> From: "Luis Antonio Castro Henriques" <[EMAIL PROTECTED]> >>> To: <[EMAIL PROTECTED]> >>> Sent: Monday, April 05, 2004 8:03 AM >>> Subject: #stop will be fixed? >>> >>> >>>> >>>> Sorry about ressurecting this issue again, but I was looking at the > cvs >>>> velocity, and looks like #stop will not be fixed any time soon. In > fact >>>> looks like the developers don�t think this is a design bug, the > proposed >>>> patch in the bug database don�t work at all (and I tryed it hard, >>>> patching manually all the files...) and nobody is looking at the >>>> issue >>>> anymore. >>>> >>>> I would like to know why this is the case, because IMHO, the > construct: >>>> #if (cond) >>>> #stop >>>> #end >>>> is very handy and without it the code became a mess of #if #else >>>> #end >>>> constructs. >>>> >>>> I am wrong? >>>> >>>> -------------------------------------------------------------------- >>>> - >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>> For additional commands, e-mail: >>>> [EMAIL PROTECTED] >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >>> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Geir Magnusson Jr 203-247-1713(m) [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
