Hi Nathan,
> as you may have noticed, i checked in a bunch of changes tonight to convert
> the VelocityView and VelocityStruts servlets and tools from singleton mode to
> the use of a VelocityEngine.
Great job! The RenderTool fix let all of my JUnit tests be completely
independent of each other. :)
> this is a Good Thing (tm) that has long been planned and requested. it does,
> however, include what some have claimed to be a Bad Thing (tm): the use of
> commons-logging. yes, it's true. VelocityView and VelocityStruts now
> primarily use commons-logging to handle log output. the only exceptions are
> the VVS and VLS classes because they have direct access to the VelocityEngine
> being used. for the rest of the classes and tools, it is entirely
> unreasonable and bad to be passing a VelocityEngine around merely to allow
> them the opportunity to access log facilities.
>
> i had put this off for some time in hopes that a magical solution might be
> found in changes to the core velocity logging facilities. these changes have
> not come, and i still doubt that they are wholly feasible.
>
> so, i've begun the (r)evolution. let all who would protest do so soon and
> back it up with working patches for their alternative proposal. :)
I am completely for this.
http://issues.apache.org/bugzilla/show_bug.cgi?id=19140
Best regards,
-- Shinobu Kawai
--
Shinobu Kawai <[EMAIL PROTECTED]>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
