ack.  ok, i've fixed this in r290281.  thanks for the pointer!

On 9/19/05, Henning P. Schmiedehausen <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] writes:
> 
> >+    protected boolean validateToolInfo(ToolInfo info)
> >+    {
> [...]
> >+        if (info.getClassname() == null)
> >+        {
> >+            LOG.error("Tool " + info.getKey() + " has no Class 
> >definition!");
> >+            return false;
> >+        }
> 
> If you add that part without the DataInfo changes, then validateToolInfo() 
> will nuke with a NPE when you add
> 
> <data>
>   <key>test</key>
> </data>
> 
> to the toolbox. It passes the first two checks (object is not null and
> key is not empty) and then calls getClassname() which is
> data.getClass().getName() with data == null. Boom.
> 
>         Best regards
>                 Henning
> 
> 
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
> [EMAIL PROTECTED]        +49 9131 50 654 0   http://www.intermeta.de/
> 
> RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
>    Linux, Java, perl, Solaris -- Consulting, Training, Development
> 
>                       4 - 8 - 15 - 16 - 23 - 42
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to