[ http://issues.apache.org/jira/browse/VELOCITY-373?page=comments#action_12329948 ]
Will Glass-Husain commented on VELOCITY-373: -------------------------------------------- Malcolm -- Took a look at the patch. Looks good, but we can't modify Parser.java. This is automatically created by javacc whenever the language syntax file (Parser.jjt) is edited. Can you restructure this in a way that doesn't require a modification to Parser.java? Otherwise this would be ready to commit. WILL > Enhance ParseErrorException > --------------------------- > > Key: VELOCITY-373 > URL: http://issues.apache.org/jira/browse/VELOCITY-373 > Project: Velocity > Type: Improvement > Components: Source > Versions: 1.5 > Environment: Operating System: other > Platform: Other > Reporter: Malcolm Edgar > Priority: Minor > Fix For: 1.5 > Attachments: ParseErrorException.txt, ParseErrorException.txt, > ParseException.txt, Parser.txt, Template.txt > > Enhance the ParseErrorException to report: > * template name (path) > * error line > * error column > The Click framework attempts to render the template error highlighting the > offending line. However when templates or macros are included in a page, the > source of the error cannot be determined from the ParseErrorException message. > If the additional properties could be added to the ParseErrorException > the framework could accurately render the offending template error. This > information should enable quicker debugging of usage errors by all Velocity > users. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
