Author: dlr
Date: Mon Sep 26 23:29:11 2005
New Revision: 291829
URL: http://svn.apache.org/viewcvs?rev=291829&view=rev
Log:
* src/java/org/apache/velocity/runtime/VelocimacroFactory.java
(addVelocimacro): Use a StringBuffer rather than String concatenation
when creating a log message in a loop.
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java
Modified:
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java
URL:
http://svn.apache.org/viewcvs/jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java?rev=291829&r1=291828&r2=291829&view=diff
==============================================================================
---
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java
(original)
+++
jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/VelocimacroFactory.java
Mon Sep 26 23:29:11 2005
@@ -360,23 +360,20 @@
}
/*
- * if we are to blather, blather...
+ * Report addition of the new Velocimacro.
*/
- if ( blather)
+ if (blather)
{
- String s = "#" + argArray[0];
- s += "(";
-
- for( int i=1; i < argArray.length; i++)
+ // The same code appears in directive.Macro
+ StringBuffer msg = new StringBuffer();
+ msg.append("Velocimacro : added new VM : #");
+ msg.append(argArray[0]).append('(');;
+ for (int i = 1; i < argArray.length; i++)
{
- s += " ";
- s += argArray[i];
+ msg.append(' ').append(argArray[i]);
}
-
- s += " ) : source = ";
- s += sourceTemplate;
-
- logVMMessageInfo( "Velocimacro : added new VM : " + s );
+ msg.append(" ) : source = ").append(sourceTemplate);
+ logVMMessageInfo(msg.toString());
}
return true;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
