[ http://issues.apache.org/jira/browse/VELOCITY-157?page=comments#action_12330764 ]
Nathan Bubna commented on VELOCITY-157: --------------------------------------- One of my first thoughts here is that perhaps we should not use Avalon as our first choice default. I know it wouldn't exactly fix the bug so much as avoid it, but really why is Avalon the default? LogKit 1.0.1 was added as a dependency well over 3 years ago and hasn't been updated since. Meanwhile, LogKit has apparently progressed to version 2.1, Avalon has been abandoned, and LogKit has since been picked up by the Excalibur project. For all I can tell, we haven't tracked with this library *at all*. Does anyone even know if Velocity works with LogKit 2.1? Do any active committers use/pay attention to this key dependency? If not, why do we make it the default? If so, where's the updates? Also, it should be noted that this issue seems to be pretty much the same as the first half of VELOCITY-193. Since the comments of that issue describe a fix for the second half (which should accompany a patch for VELOCITY-78), once VELOCITY-78 is resolved as planned, we should be able to resolve VELOCITY-193 as a duplicate of this bug. As for fixing this bug, well, i might dig up some time to look into it, but i make no committment to it. http://svn.apache.org/viewcvs.cgi/jakarta/velocity/core/trunk/build/lib/logkit-1.0.1.jar?rev=190558&view=log http://www.apache.org/dist/excalibur/avalon-logkit/binaries/ http://issues.apache.org/jira/browse/VELOCITY-193 http://issues.apache.org/jira/browse/VELOCITY-78 > velocityEngine.init opens velocity.log multiple times > ----------------------------------------------------- > > Key: VELOCITY-157 > URL: http://issues.apache.org/jira/browse/VELOCITY-157 > Project: Velocity > Type: Bug > Components: Source > Versions: 1.3.1-rc2 > Environment: Operating System: All > Platform: PC > Reporter: Hendrik Brummermann > Priority: Critical > Fix For: 1.5 > Attachments: Test.java > > velocityEngine.init opens velocity.log multiple times Every call to > velocityEngine.init() opens velocity.log several times. Frequent calls to > .init() (e.g. in doGet/doPost) will use up all file descriptors of the > operation system. This is a critical problem because Windows 2000 deletes > all files that a process wants to open after Windows has no more file > descriptors left. (On Windows NT 4.0 you get "Too many open files" and > nothing is deleted) Steps to reproduce: 1. java Test (see attachment) 2. > While Test is still running do: a) GNU/Linux: lsof | grep velocity.log|wc -l > b) Windows: handle | find "velocity.log" (You can get handle.exe from > http://www.systeminternals.com) Expected Result: velocity.log should be > opened one or a few times. Actual Result: velocity.log is opened 900 times > (9 times per call to "init"). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
