[ http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12330774 ]
Will Glass-Husain commented on VELOCITY-403: -------------------------------------------- Wow, that's quite the patch. Cleans up a lot of annoying issues. Definitely for inclusion in 1.5. Thanks too for the detailed description - very useful. Two comments. The first is minor. Introducing JDKLogSystem is our first JDK 1.4 dependency. I'd like to leave this out (maybe put it in the Wiki). The second is more significant. Changing LogSystem means that this is not a drop-in replacement for existing installs. For example, my main Velocity-based app implements LogSystem. It's superfluous (I should probably change this to use one of the built-ins) but I don't like making users change APIs simply to upgrade a library. I suggest we define LogInterface (or similar name) that extends LogSystem. Have all internal uses of the LogSystem change to LogInterface. Recommend in the docs that LogInterface be used. When the user configures a logger, check to see if it is LogSystem or LogInterface. if it is LogSystem then wrap it in an adapter LogSystemToInterface so that it has the full API for internal use. Comments? > Enhance Velocity's LogSystem and internal use thereof > ----------------------------------------------------- > > Key: VELOCITY-403 > URL: http://issues.apache.org/jira/browse/VELOCITY-403 > Project: Velocity > Type: Improvement > Components: Source > Reporter: Nathan Bubna > Fix For: 1.5 > Attachments: logging.patch > > After several very, very long debates with Geir over commons-logging, i have > become largely convinced that it is something we should do with hesitation > (i.e. let's talk about it for 2.0, but not before). i've also begun to have > some frustrations with commons-logging in both work projects and in > VelocityTools. > regardless of these issues, it is clear to me that Velocity's LogSystem and > use of it is in great need of improvement. we need to lower the priority of > many messages, eliminate some, and above all, upgrade the system itself to be > more useful. > some specific, unevaluated, off-the-cuff ideas are: > -make logging a null-op if no logger is found, rather than panic and break > -detect jdk 1.4+ logging > -add a trace level > -add is<Level>Enabled > -make it possible to grab a LogSystem instance of sorts, so Velocity > extensions can use it more sensibly (i'm tired of the hacks we must do in > Tools) > those are just a few ideas, and they might not all even be feasible. still, > i'm hoping to take a whack at some of this and hoping that others can help me > out. my volunteer time is still rather limited. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
