[ http://issues.apache.org/jira/browse/VELOCITY-78?page=comments#action_12331028 ]
Nathan Bubna commented on VELOCITY-78: -------------------------------------- Yes, and no. This bug affected both Log4JLogSystem and the deprecated SimpleLog4JLogSystem. the patch for VELOCITY-403 fixes the bug in Log4JLogChute (and thereby Log4JLogSystem) and uses Log4JLogChute in the default velocity.properties instead of SimpleLog4JLogSystem. so, the bug will be fixed for almost everyone. however, anyone outdated enough to have explicitly specified SimpleLog4JLogSystem (which has been deprecated for eternity and will now generate deprecation warnings at init-time) will not have the bug fixed for them. it would be easy to fix SimpleLog4JLogSystem, but frankly, i didn't care to. now it's just one more reason to stop using an ancient class. > SimpleLog4JLogSystem closes appenders > ------------------------------------- > > Key: VELOCITY-78 > URL: http://issues.apache.org/jira/browse/VELOCITY-78 > Project: Velocity > Type: Bug > Components: Source > Versions: 1.3-rc1 > Environment: Operating System: other > Platform: All > Reporter: Steven Hugg > Priority: Minor > Fix For: 1.5 > > The SimpleLog4JLogSystem class closes all appenders in its shutdown() method, > even if the appenders were not created by Velocity. This can cause problems > if > the logging system is initialized in your servlet, and if Velocity instances > are finalized while other instances are in use -- since Log4J Categories are > static :P > What should probably happen is a flag should be set so that appenders are > only > closed if they were created by the SimpleLog4JLogSystem class, and/or when > all > Velocity instances are GC'ed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
