[ http://issues.apache.org/jira/browse/VELOCITY-166?page=comments#action_12331174 ]
Nathan Bubna commented on VELOCITY-166: --------------------------------------- Hmm. yes, and no. :) if there is no valid value for runtime.log.logsystem.class then the LogManager will use StandardOutLogChute. in this way, the issue is somewhat solved. however, the person is requesting that the lack of a "runtime.log = foo.log" property be the trigger for turning off logging. this will not happen. in fact, given the way this person reports a PANIC and exception strongly implies that they had log4j in their classpath and is using the default "runtime.log.logsytem.class" values (which include Log4JLogChute), but had neither a "runtime.log" value nor a "runtime.log.logsystem.log4j.logger" (actually "runtime.log.logsystem.log4j.category" in this older case) property. in such a case, the LogManager will pick the Log4JLogChute and the same PANIC message should happen. personally, i think this issue should be closed as WONTFIX. the user clearly has not RTFM'd or they would realize that removing the "runtime.log" default property is not at all the right way to disable logging. nor do i think it should ever be. the key property is the runtime.log.logsystem.class one. still, improvements could probably be made to the error reporting and/or fallback options when an exception occurs during the init of one the default log chutes. it might be as simple as not catching the exception in lines 74-83 (rev293366) of Log4JLogChute (or any other init exceptions in any LogChute/System) and letting it propogate up to LogManager which will then fallback to the next option. > avoid setting up file logging > ----------------------------- > > Key: VELOCITY-166 > URL: http://issues.apache.org/jira/browse/VELOCITY-166 > Project: Velocity > Type: Improvement > Components: Source > Versions: 1.3.1 > Environment: Operating System: All > Platform: All > Reporter: Jens Elkner > Priority: Minor > Fix For: 1.6 > > Please avoid trying to setup file logging, if RuntimeConstants.RUNTIME_LOG > property is not set or empty. The thrown exception (e.g. in > SimpleLog4JLogSystem#init) is misleading! Having no [file] logging > set, AFAIK has no implications on the production of the results, > so it is neither a PANIC situation nor worth for a warning message. > I would at max. assign it to the INFO level, speaking in terms of a log > system... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
