[ http://issues.apache.org/jira/browse/VELOCITY-166?page=all ]

Nathan Bubna updated VELOCITY-166:
----------------------------------

    Attachment: morerobust.logging.patch

Will,

here's a patch that will make the handling of LogChute init() more robust.  it 
should make exceptions during the initialization of either the AvalonLogChute 
and Log4JLogChute fallback gracefully to the next option (StandardOutLogChute 
being, of course, the final resort).  it also handles errors during the 
initialization of LogChute/System instances passed in via the 
runtime.log.logsystem property more robustly.

with the commit of this patch, there would be (IMHO) ample reason to mark this 
issue resolved.

> avoid setting up file logging
> -----------------------------
>
>          Key: VELOCITY-166
>          URL: http://issues.apache.org/jira/browse/VELOCITY-166
>      Project: Velocity
>         Type: Improvement
>   Components: Source
>     Versions: 1.3.1
>  Environment: Operating System: All
> Platform: All
>     Reporter: Jens Elkner
>     Priority: Minor
>      Fix For: 1.6
>  Attachments: morerobust.logging.patch
>
> Please avoid trying to setup file logging, if RuntimeConstants.RUNTIME_LOG
> property is not set or empty. The thrown exception (e.g. in
> SimpleLog4JLogSystem#init) is misleading! Having no [file] logging
> set, AFAIK has no implications on the production of the results,
> so it is neither a PANIC situation nor worth for a warning message.
> I would at max. assign it to the INFO level, speaking in terms of a log 
> system...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to