Hi Nathan,
Good catch.
You probably knew this but here's how to edit this code.
1) Edit build.xml to point to your copy of javacc. (must be 3.2 or later).
1) Edit parser.jjt
2) Run "ant parser" -> generates 5 files.
3) If necessary, convert the line endings for ParserTokenManager.java to
your native platform
(other files are ok - for some reason this is always Unix).
4) Compile, run ant test, and check in
Best,
WILL
----- Original Message -----
From: "Nathan Bubna" <[EMAIL PROTECTED]>
To: "Velocity Developers List" <velocity-dev@jakarta.apache.org>
Sent: Thursday, October 06, 2005 9:15 AM
Subject: Re: svn commit: r306522 - in /jakarta/velocity/core/trunk:
src/java/org/apache/velocity/runtime/parser/ test/templates/
test/templates/compare/
On 10/6/05, Nathan Bubna <[EMAIL PROTECTED]> wrote:
On 10/5/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> Author: wglass
> Date: Wed Oct 5 21:25:59 2005
> New Revision: 306522
>
> URL: http://svn.apache.org/viewcvs?rev=306522&view=rev
> Log:
> fixed bug with parse error when comment was last line of file.
> VELOCITY-272
>
> Added:
> jakarta/velocity/core/trunk/test/templates/comment-eof.vm
> jakarta/velocity/core/trunk/test/templates/compare/comment-eof.cmp
> Modified:
>
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.java
>
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.jj
>
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.jjt
>
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/ParserConstants.java
>
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/ParserTokenManager.java
> jakarta/velocity/core/trunk/test/templates/templates.properties
>
> Modified:
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.java
> URL:
> http://svn.apache.org/viewcvs/jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.java?rev=306522&r1=306521&r2=306522&view=diff
> ==============================================================================
> ---
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.java
> (original)
> +++
> jakarta/velocity/core/trunk/src/java/org/apache/velocity/runtime/parser/Parser.java
> Wed Oct 5 21:25:59 2005
> @@ -109,12 +109,12 @@
> * thrown by the Macro class when something is amiss in
> the
> * Macro specification
> */
> - rsvc.getLog().error("Parser Error: #macro() : " +
> templateName, mee);
> + rsvc.error ("Parser Error: #macro() : " + templateName + "
> : " + StringUtils.stackTrace(mee));
can we not revert to using deprecated methods? :)
ah ha. just noticed that Parser.java is generated. i missed that
when speeding through my logging upgrades... i'll see if i can figure
out how to fix this myself. :)
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
