I took a quick look at the code. Seems like we can remove the need to
include a reference to Parser in ASTDirective by passing in a direct
reference to the directive instead.
By "init the top node" method, I assume you mean we would require the user
to call init(RuntimeServices) after deserializing?
WILL
----- Original Message -----
From: "Serge Knystautas" <[EMAIL PROTECTED]>
To: "Velocity Developers List" <velocity-dev@jakarta.apache.org>
Sent: Sunday, February 26, 2006 8:11 PM
Subject: Re: Avoid reparsing velocity templates
On 2/26/06, Llewellyn Falco <[EMAIL PROTECTED]> wrote:
if everything isn't serializable, checkout the code and make it
serialiable
shouldn't take very long, doubt even 15 minutes to add implements
serializable to the nessicary classes.
The problem I see is that every extends SimpleNode, which holds
references to RuntimeServices and Parser, neither of which are really
serializable. The RuntimeServices seems manageable since you can init
the top node and it will descend and set the variable everywhere else
(hopefully that's all init does). Parser is a bit harder to extract,
but really only because of one place... ASTDirective uses it in the
init method.
out of curioustity 700 ms / mb ? i've never seen a template so big....
I had 4 sized templates (tiny 102b, medium 4kb, large 60kb, huge
243kb) of the same Velocity script repeated, ran them thousands of
times, then adjusted the units to express it as duration per MB.
Yeah, not really that big. :)
--
Serge Knystautas
Lokitech >> software . strategy . design >> http://www.lokitech.com
p. 301.656.5501
e. [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
