[ http://issues.apache.org/jira/browse/VELOCITY-227?page=comments#action_12447468 ] Nathan Bubna commented on VELOCITY-227: ---------------------------------------
I don't think so. I believe the request is for a change in the ResourceManagerImpl to make it more easily extendable, not the ResourceManager interface. Breaking part of a larger method of an implementation out into another protected method should never break classes that override the implemenation and is irrelevant for other implemenations of the same interface. > ResourceFactory not extensible > ------------------------------ > > Key: VELOCITY-227 > URL: http://issues.apache.org/jira/browse/VELOCITY-227 > Project: Velocity > Issue Type: Improvement > Components: Engine > Affects Versions: 1.5 > Environment: Operating System: All > Platform: All > Reporter: Charles Morehead > Priority: Minor > > The class org.apache.velocity.runtime.resource.ResourceFactory provides > no mechanism for allowing sub-classes of Template or ContentResources > to be returned. > Since ResourceManagerImpl makes a call to ResourceFactory.getResource(), > the only way to override the behavior is to subclass ResourceManagerImpl > and cut-paste-then-modify the code for loadResource(). > At the very least, moving the ResourceFactory.getResource() call into > a separate, protected method in ResourceManagerImpl would greatly simplify > sub-classing Templates and/or ContentResources. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
