Hey,

 >> Cheers. One minor hint for ultimate code quality:
>>     if (a == 0.0)
>> will lead to a conversion warning as well as a warning on
>> equality-comparisons of floating point numbers when passing -Wconversion
>> to Clang (and probably GCC and Visual Studio with appropriate flags).
>> The fix in this case is to use
>>     if (a <= 0)
>> or
>>     if (!a)
>> which silences these. There are probably a few more such things in the
>> code and will be eliminated once towards each release, but it's good to
>> be aware of it :-)
>
> Quite -- fixed; it's good to know where these idiosyncrasies crop up
> when translating mathematics to computer science..

Indeed. You'll certainly find many more of these over time ;-)

Thanks and best regards,
Karli

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
ViennaCL-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/viennacl-devel

Reply via email to