Sigurd Meldgaard <[EMAIL PROTECTED]> writes:

Excellent tests -- I like the idea of testing both equal and unequal
numbers, this is actually something which we ought to test with the
other binary operators too.

> # HG changeset patch
> # User Sigurd Meldgaard <[EMAIL PROTECTED]>
> # Date 1221574270 -7200
> # Node ID 5aa168c8778a1e2909cda7c1ea08da8501b66a95
> # Parent  a0b713380c029ca32f42e5fa1b4d8752f74e578b
> Test of robabilistic equality mix-in

Typo    ^^^

> * * *

I bet those stars are the result of a qfold command... it has this funny
default of merging the commit messages with "* * *" inbetween. Could you
qrefresh and delete it?

> +class EqualRuntime(Runtime, ProbabilisticEqualityMixin):
> +    """A runtime with the equality mixin."""
> +    pass
> +
> +
> +class ProbabilisticEqualityTestDifferent(BinaryOperatorTestCase,
> +                                         RuntimeTestCase):
> +    """Testin the equality with a and b different."""

Missing "g"   ^^^ I think I saw this two times more.

> +class ProbabilisticEqualityTestDiff1_2(BinaryOperatorTestCase,
> +                                       RuntimeTestCase):
> +    """Testin the equality with a and b different by only in the other

Here too :-) And I think there is a "one" missing here ^

> +    direction."""
> +    a = 1
> +    b = 0
> +    runtime_class = EqualRuntime
> +    operator = operator.eq

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multi-Party Computation) to Python. See: http://viff.dk/.

Attachment: pgp1cdjiBkYFd.pgp
Description: PGP signature

_______________________________________________
viff-patches mailing list
[email protected]
http://lists.viff.dk/listinfo.cgi/viff-patches-viff.dk

Reply via email to