"Sigurd Torkel Meldgaard" <[EMAIL PROTECTED]> writes: >> > diff -r 5aa168c8778a -r f879ad687faa viff/runtime.py >> > --- a/viff/runtime.py Tue Sep 16 16:11:10 2008 +0200 >> > +++ b/viff/runtime.py Tue Sep 16 16:07:10 2008 +0200 >> > @@ -1079,6 +1079,19 @@ >> > result.addCallback(shamir.recombine) >> > return result >> > >> > +def make_runtime_class(runtime_class = Runtime, mixins = ()): >> >> No space around default arguments in functions. Also, I don't think >> it makes sense to give mixins as default argument -- people should >> only use this function if they actually have something to mix. > > The default arguments are more for being able to call the function > with keyword-parameters - often you want the runtime_class to be > the default value, but you do not want it to go after the mixins > ... good ideas? One possibility is to special case like:
Remove the default from both arguments? Or make runtime_class the last argument? >> Great idea with such a function so that people wont have to do the >> scary dynamic class stuff themselves -- could you please make >> another patch which updates apps/benchmark.py to use this function? > > Sure Great, thanks! Another idea: it would be fun to have support for testing equality in benchmark.py... you could do a patch for that if you have the time :-) -- Martin Geisler VIFF (Virtual Ideal Functionality Framework) brings easy and efficient SMPC (Secure Multi-Party Computation) to Python. See: http://viff.dk/. _______________________________________________ viff-patches mailing list [email protected] http://lists.viff.dk/listinfo.cgi/viff-patches-viff.dk
