Just realized that some of the comments in the suite.py are outdated.
This is confusing. Here is an update:


diff -r e01382aea278 apps/benchmark/suite.py
--- a/apps/benchmark/suite.py   Fri Nov 07 01:11:24 2008 +0100
+++ b/apps/benchmark/suite.py   Fri Nov 07 09:45:58 2008 +0100
@@ -45,7 +45,6 @@


     Issues:
-        Looks like the first run takes longer time than the rest. Is that ok?
         Results for all runs for a benchmark is kept in memory at once.
             Problem?
         Currently master only works on *nix since we use select.
@@ -55,7 +54,6 @@
             system and that the dir supplied to the suite is on this shared
             file system.
         Can we run multiple benchmark slaves on one host?
-        Currently, default parameters are always used, e.g. use_ssl = no.
         Support for string, float and boolean results. Currently only integers
             (up to Mysql.BIGNUM) are supported.
         We assume that python setup.py install --home=$HOME/opt overwrites old
@@ -67,8 +65,8 @@
             runs; this is ok if benchmark doesn't measure bandwith or time, and
             it is (presumably) faster.
         The table TimedResults cannot be used yet.
-        The benchmark suite must be run in the viff/benchmark dir due to scp
-            copy of the benchmark classes, ok?
+        The benchmark suite must be run in the viff/apps/benchmark dir due to
+            scp copy of the benchmark classes, ok?
         Better documentation.
         Security. Currently, password to the mysql db is supplied on the
             command line both in example.py and when executing benchmark.py on
@@ -78,9 +76,6 @@
         Can't get the popen objects to finish when ssh finishes, so I've done a
             hack by letting each benchmark write COMPLETED WITH RETURNCODE x as
             the last thing. Not pretty, but it works (at least now..)
-        Non-VIFF benchmarks are always run on the same host that starts the
-            suite. It probably would be nice to be able to specify which host
-            to use for the benchmark.
         VIFFBenchmark reports back to master on the fly. Would also be nice
             if non-VIFF benchmarks did that.
_______________________________________________
viff-patches mailing list
viff-patches@viff.dk
http://lists.viff.dk/listinfo.cgi/viff-patches-viff.dk

Reply via email to