Janus Dam Nielsen <[email protected]> writes: > # HG changeset patch > # User Janus Dam Nielsen <[email protected]> > # Date 1240830884 -7200 > # Node ID 4cbb298a7ed8db12facfeafe40febbc24bc79701 > # Parent 4397d64715c625445b0170daf5dfed39ac769219 > Added comment to method signed()
Great, terse! :-) > diff --git a/viff/field.py b/viff/field.py > --- a/viff/field.py > +++ b/viff/field.py > @@ -506,7 +506,8 @@ > return (self.value >> index) & 1 > > def signed(self): > - """ > + """Return a signed integer representation of the value. > + > if x > floor(p/2) then subtract p to obtain negative integer Please start the sentence with a capital letter and end it with a full-stop (.). > """ > if self.value > ((self.modulus-1)/2): > @@ -515,7 +516,7 @@ > return self.value > > def unsigned(self): > - """Returns a unsigned representation of the value""" > + """Return a unsigned representation of the value""" > return self.value This change should go into the first patch -- there is no need to send patches which correct mistakes in earlier patches. Instead you should 'qfold' them into one good patch. -- Martin Geisler VIFF (Virtual Ideal Functionality Framework) brings easy and efficient SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
pgpUgOFIrjLXs.pgp
Description: PGP signature
_______________________________________________ viff-patches mailing list [email protected] http://lists.viff.dk/listinfo.cgi/viff-patches-viff.dk
