Robert Norris <rw_nor...@hotmail.com> writes:

> I've made my first set of Auto View (Zoom) improvements. Please see:

cool!  I am making a lot of suggestions and "it would be cool" etc. and
don't mean to sound complaining.

> http://github.com/rnorris/viking/tree/AutoZoom

I fetched, and 'git checkout AutoZoom' created a tracking branch even
though your repo is of course not my primary remote.

> Here on opening GPX files it zooms out to the full layer extent* 

> *I don't think viking should guess whether tracks or waypoints are
> more important,

Sure, that's fair.  (FWIW, I have separate waypoint and track files;
track files are named by dates and waypoint files are once in a while.)

> and in the case above it would center on the track in
> a zoom level that encompasses that track - since that is the last one
> processed.

So you're saying that the zoom is set to the last gpx file processed?
That would then be easy for me to make it do what I want.  But it seems
to zoom to the max of all (haven't read code, just trying it).

> Options have been added to the Layer's menus to zoom to view the layer
> / individual track / all waypoints.

> NB if in the current zoom level, it can cover the view - then it does
> not attempt to zoom in to find the 'best' zoom level.

I don't understand that choice.  In my case, I have a waypoints file
with a waypoints in far away places (near Boston, near San Diego, and a
few others).  I want to see waypoints when they're near what I'm looking
at, but if I say "show me the track gpx" I would like it to zoom to just
fit the gpx data in that layer.


> Possible improvements can be:
>
> . Set the view upon getting info from a GPS.

probably that should be a checkable/sticky "keep GPS position onscreen",
and it should then cause panning gps to center when gps goes outside of
some area.  not clear what it should do about zoom; my vote is don't touch.

>        - I'm not quite sure ATM, how to feedback the TrackWaypoint
> layer created from the babel / acquire thread stage.

>        - Possibly make this behaviour optional, but I don't see why
> one would *not* want to see the data just acquired!

> . If this feature is deemed really useful, add an icon in toolbar for
> layer auto view, [maybe GTK_STOCK_ZOOM_FIT]

> . Find best fit zoom mode (i.e. view may zoom in as well).



What about changing the default to zoom from pan?  I use middle mouse to
pan when in zoom mode, so pan seems far less useful.

It would be cool for dragging in zoom mode to zoom to that rectangle.



I read the code.  Specific comments:

  'view waypoints' is attached to a single waypoint menu-wise, but is
  about the layer.   'view waypoint' 

  'view track' is cool, and it might be useful to have 'view tracks' on the
  tracks part of the gpx.

  'view layer' on the whole layer zooms out to show the layer, but I
  would like it to zoom in to the closest view that shows the whole
  layer.   perhaps don't zoom more than xmpp=0.5.


Generally, I think it would be nice to articulate a zoom/pan policy and
rationalize all the goto/show to follow it consistently.  I think that's:

  the following don't change zoom level:

    goto waypoint
    goto center of layer / track / etc.
    following live gps position from gpsd

  the following set zoom to the maximally zoomed-in that works, but no
  zoomier than .5 or 1

    view gpx file
    view tracks
    view waypoints



All in all I think your branch is a big improvement and +1 for merging
to master.

Attachment: pgpvbdOO5YblA.pgp
Description: PGP signature

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to