Quick review of the case change: a large comment is removed, and there is no replacement comment explainining the plan
in paricular, the missing new comment doesn't explain why the new way causes no regressions new procedures don't have comments explaining their purposes (even though it's fairly easy to guess) commit message does not describe the change first, but rather is a history of why. The huge list of symbols is a) confusing - I'm not sure what "couldn't be checked" means and b) too detailed for the commit message The commit message, or the mail sent to the list announcing it, does not say what you have regression tested. thanks for putting this up on a public git repo - that made looking at it easy. For others, the URL is http://git.open-mesh.org/?p=ecsv/viking.git;a=summary
pgpt7PNOa0UZ8.pgp
Description: PGP signature
------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d
_______________________________________________ Viking-devel mailing list Viking-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/viking-devel Viking home page: http://viking.sf.net/
