----------------------------------------
> Date: Sun, 11 Sep 2011 08:51:49 +0200
> From: g...@muellers.ms
> To: viking-devel@lists.sourceforge.net
> Subject: Re: [Viking-devel] Tiles get deleted in offline mode
>
> Hi,
>
> I just noticed, that this bug is back in latest git trunk.
>
> I already filed a bug report and it got resolved, but it seems
> viking is now again deleting tiles if auto download map is enabled
> and there is no connection to the internet.
>
> Can one of the superusers please reopen this bug
> http://sourceforge.net/tracker/?func=detail&aid=3042692&group_id=83870&atid=570954
>

This took a while but I think I understand this now (limited by my git fu 
knowledge)....

The offending line is in download.c at line 241:
   g_remove ( fn ); /* couldn't create temporary. delete 0-byte file. */

This was originally fixed by commit 4945e425d481ca7b9a4c6e00a8e11bff79d254a4 by 
Jocelyn back in 2010-09-13.

*HOWEVER*, it appears that by the subsequent merging of the remote branch 
'jocelyn/etag' on 2010-10-11 this somehow restores the offending line.
[I don't quite understand how/why this line was restored but the second chunk 
of the patch is kept - I can't seem to track an exact commit where it actually 
changes!**]

** If anyone can find the exact reason / commit why this happened - please 
explain as I would like to understand.

Anyway, this means the fix never made it into any official Viking release.

I'll fix the trunk.


Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.


                                          
------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to