Hi, 2012/8/28 Robert Norris <rw_nor...@hotmail.com>: > I think it's probably due to commit f01eebd4992e8e28a74b9943b7a3597e4e3a95eb: > > "Fix: Improve internal redrawing method. > > Should now have no race conditions / lock outs to be more reliable when > handling (e.g. downloading) multiple sources and redrawing the screen at any > time by using the appropriate gtk idle drawing methods for all updates." > > So I think it exposes something in GTK's 'idle redrawing' that doesn't redraw > fast enough on Windows, so it's not a simple bug to fix.
I'm unable to test this (no windows@home). So, I only review this commit. I'm unable to do some experiment, but here are some though, in the hope this can help finding the bug. I notice 3 changes in this commit: - introduction of thread communication via "idle" tasks - a new redraw condition (in dem_layer_download_release) - an optimisation to avoid locking GDK mutex recursively. Without any more inputs or experiments, it's hard to identify what can be wrong. I imagine that the most sensible change is certainly the third one. I don't say this is the problem, I only point this si certainly a sensible change. I also notice that some critical sections, initialy protected by GDK lock, have been reduced. But the newly exposed code seems thread safe, or protected by other mutex (for example in dem_download_thread). If more experiments confirm that this commit is guilty, I suggest to try changing vik_layer_emit_update in order to always use gdk_threads_add_idle. PS: I also noticed that the following page have comment about win32 backend, but I do not understand how to interpret. http://developer.gimp.org/api/2.0/gdk/gdk-Threads.html -- Guilhem BONNEFILLE -=- JID: gu...@im.apinc.org MSN: guilhem_bonnefi...@hotmail.com -=- mailto:guilhem.bonnefi...@gmail.com -=- http://nathguil.free.fr/ ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Viking-devel mailing list Viking-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/viking-devel Viking home page: http://viking.sf.net/
