> Hi, > > I've had a go at implementing an "extended" route finding tool for Viking. > I'm sending this mail to
Great to hear a new name interested in this project! > 1) see what you think of the tool, whether i'm trampling over any work in > progress, and whether it would be suitable to add to Viking proper, and AFAIK no else is doing this. It is definitely suitable for inclusion in Viking. I assume you know there is the 'Extend using Route Finder' on the right click menu of a Track/Route. However I believe this new tool mode makes this kind of work flow much easier. > 2) get some code review, since i just dived into a large project and > hacked around until it worked... That's how I work... :) Unfortunately C can be quite pernickety, as you have encountered with the bug you fixed below. > The idea is that it is a more direct version of the "refine route" option. > The interface more or less behaves like the "create route" tool. On the first > click the user is asked for the name of the route to be created; then, route > points are added each time the user clicks (with the UI showing route points > and connecting lines). The twist is that each time the user adds a route > point, the default routing web engine is queried to find a route between the > last point of the track and the new point to be added. The user presses > "escape" to finish the planning, or "backspace" or right-clicks to undo the > last search (and skip back to the penultimate manually entered route point). I've yet to read/run the code in detail - that will be some time over the week, but here are some first thoughts: My first instinct it to improve the naming of this feature, I'm thinking of calling it like 'Assisted Routing' - 'Create Route using Online Routing'. Indeed I don't think it's extended - it's simpler! I've come to the believe asking for the name of the track/route before actually creating it is quite annoying. However I don't suggest you need to change your workings - I'll clean it all up I one go some day. > The implementation is available here > > https://github.com/yourealwaysbe/viking-extended-route-finder > > as a fork of the main git repository. At the moment i'm just using the same > button icon as the route finder. I'm hardly a UI guru, but probably the simplest way is just create a copy of the create route icon and just adjust the colours to make it suitably different to contrast with the standard route create. Alternatively with more effort and/or graphic flair required would be to create an new icon from an amalgamation of 'Online' and routes graphics. E.g. something like the GTK_STOCK_NETWORK overlaid by the create route icon. > > As part of the implementation i also fixed > > vik_track_cut_back_to_double_point > > in viktrack.c, since it was casting trackpoints to co-ordinates rather than > extracting the coord field of the trackpoints. It's best to keep fixes / reworkings etc... as separate individual commits from new feature commits. By the way it looks like I 'broke' the above function by inserting a new data field into the beginning of the VikTrackpoint structure: http://sourceforge.net/p/viking/code/ci/f629b00b58bf2a9ff9d115ab3b6469ee50e5e836 However the fault is implicitly assuming the coordinates are at the start of the memory location. Solved by referring to the (visible) internal field directly - as in the way you fixed it. > Let me know what you think. > > Best, > > Matt > Be Seeing You - Rob. If at first you don't succeed, then skydiving isn't for you. ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Viking-devel mailing list Viking-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/viking-devel Viking home page: http://viking.sf.net/
