Hi,

I've been looking at trw code and I noticed one possible problem in code
drawing track. Can you please take a look?

The problem is with this code in viktrwlayer.c (~line 2452):

/*
 * If points are the same in display coordinates, don't draw.
 */
if ( x != oldx && y != oldy )
    {
      vik_viewport_coord_to_screen ( dp->vp, &(tp2->coord), &x, &y );
      draw_utm_skip_insignia ( dp->vp, main_gc, x, y );
    }

Shouldn't the condition be rather "x != oldx || y != oldy"? Similar block
of code is present few lines above, but the condition contains "||" instead
of "&&":

/*
 * If points are the same in display coordinates, don't draw.
 */
if ( x != oldx || y != oldy )
    {
      if ( draw_track_outline )
        vik_viewport_draw_line ( dp->vp, dp->vtl->track_bg_gc, oldx, oldy,
x, y);
      else
        vik_viewport_draw_line ( dp->vp, main_gc, oldx, oldy, x, y);
    }


Best regards,
Kamil
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to