Thank you for your continued diligence.

Fixes addressing both these issues have been pushed into the latest source code.

Albeit the Travis CI seems to have broken itself on 2 of the 3 Ubuntu builds...

--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.

________________________________________
From: Kamil Ignacak <kamil.igna...@gmail.com>
Sent: 23 October 2018 21:49
To: viking-devel
Subject: [Viking-devel] Two issues: copyright notice and g_free()

Hello,

I have spotted two minor issues in viking source code, can you please verify 
them?

1. vikwebtoolformat.c/h files have an error in copyright notice: both of them 
contain reference to "GNU *Format* Public License". Probably a result of global 
search&replace.
2. call to g_free() in line 112 of compression.c file appears to be unnecessary:
    if (GUINT32_FROM_LE(local_file_header->sig) != 0x04034b50) {
        ...
        g_free(unzip_data);
        goto end;
    }
It's not an error because g_free() can handle NULL pointer argument just fine.

Best regards,
Kamil


_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to