Hello,

I've been reviewing code in viktrwlayer_analysis.c and came upon
include_invisible_toggled_cb() callback. One thing that I noticed is that
the function re-generates a list of tracks and layers on every call, i.e.
every time an "include invisible" checkbox is toggled.
The contents of the list does not depend on the state of the checkbox, so
every time the list is the same. The state of checkbox only influences
which elements of the list are processed in later stages.

I can imagine that current implementation may be useful if list of tracks
changes in the background (new tracks are being removed or added) - user
just has to click twice to get a new, current list of tracks. Was this the
reason behind re-generating list of tracks and layers on every checkbox
toggle?

Best regards,
Kamil
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to