NB We spoke about the $RANDOM issue back in November 2016.

I still don't really understand how this creeps in from the automake build 
system, nor do I wish to dig deep enough into automake to find out why.

I noticed on my build system I had seemingly quite old copy of various *.m4 
files (from 2013!) in Viking's local m4/ directory. However upon refreshing 
everything it made absolutely no difference to the generated configure file.

So I suppose you are using the one of the compressed releases of VIking and 
running the './configure' file provided directly? Since the 'configure' file 
itself is generated on my Debian Linux machine I guess it therefore thinks 
$RANDOM is available.

Perhaps you should try running the autotools stuff directly to generate the 
configure file for your system(s).
c.f. When acquiring Viking directly from source code repository there is no 
configure file; so here one needs to run the ./autogen.sh script to generate 
one. However ATM autogen.sh is not in the compressed releases.

I don't why Viking would be any different to any other typical program 
autotools build systems though.

--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.


________________________________________
From: Greg Troxel <g...@lexort.com>
Sent: 18 March 2020 13:36
To: viking-devel@lists.sourceforge.net
Subject: [Viking-devel] another portability nit

In configure, we patch

  $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.$$RANDOM

to

  $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.not-random

$RANDOM is a bashism not specified by POSIX, and not available in a
number of shells.  (It is available in NetBSD's /bin/sh, but pkgsrc has
a bunch of portability checks because pkgsrc does not require that a
platforms /bin/sh have anything beyond what POSIX requires.)


I'd suggest changing to


  $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.viking.$$$$

I have not tested; I am guessing this passes $$ to the shell after make
quoting.

That should be enough not to collide, even if there are multiple viking
builds happening at once.



_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/


_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Reply via email to