Hello,
I have noticed few minor inconsistencies in source code of Viking that
I would like to report here.
1. vikgpslayer.c/gps_layer_get_param()
Assignment of boolean to integer field of an union:
case PARAM_REALTIME_UPDATE_STATUSBAR:
rv.u = vgl->realtime_update_statusbar;
break;
In gps_layer_set_param() the value of the parameter is (correctly)
taken from boolean field of the union:
case PARAM_REALTIME_UPDATE_STATUSBAR:
vgl->realtime_update_statusbar = vlsp->data.b;
break;
Since these are fields of an union it shouldn't really matter.
2. vikmapslayer.c/maps_layer_set_param()
Similar issue as above, assignment from integer field of union instead
of boolean (for two parameters):
case PARAM_AUTODOWNLOAD: vml->autodownload = vlsp->data.b; break;
case PARAM_ONLYMISSING: vml->adl_only_missing = vlsp->data.b;
break;
Best regards,
Kamil
_______________________________________________
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/
