On Tue, Oct 10, 2006 at 01:40:04PM +0100, Edd Barrett wrote:
> On 01/10/06, Edd Barrett <[EMAIL PROTECTED]> wrote:
>
> > Hope your enjoying your weekend.
> >
> >As promised i have ammended the patch.
>
>
> Hi Guys,
>
> I havent recieved any feedback on this patch yet, did anyone get a
> chance to look at it?
>
> Sorry to be a bore.
>
> Best Regards
>
> Edd
Be careful about what you ask (or wish) for: you just might get
it! ;)
The samples look fine to me (using Mozilla 1.7.12 on Linux). I
would like to see an example where the background color changes, if only
so that I can see some situation where
<span class="foo"> (text) </span>
looks simpler (by rudimentary measures such as character count) than
<font color="#EEE"> (text) </font>
How does the encoding get set? For example, in xhtml.html I see
<?xml version="1.0" encoding="iso-8859-1"?>
If I have
:set enc=utf-8
will I get utf-8 in that line?
Have you actually tested for W3C compliance?
Very minor points: you might want to change the line
if exists("html_font")
to
if exists("g:html_font")
Some readers will find this clearer, and if those lines ever get wrapped
in a function, then it will actually make a difference. Please fix the
indentation in places like this:
- if exists("use_xhtml")
- let s:LeadingSpace = ' '
- else
let s:LeadingSpace = ' '
- endif
HTH --Benji Fisher
