Frodak wrote:
> >Building a binary with both os_unix.c and os_mswin.c sounds like a bad
> >idea. The big #ifdefs are quite a hack. On the other hand, moving this
> >to a generic file, such as ui.c, also doesn't seem a good plan. How
> >about moving this code to a new file, e.g., winclip.c?
>
> It was pretty ugly wasn't it. I've moved it to winclip.c. I've
> updated all of the make and prototype files. I ran make -f
> Make_cyg.mak, didn't have any issues with compiling.
>
> >Including windows.h in os_unix.c looks like a mistake. There should not
> >be windows code in a Unix-specific file. You probably have to move some
> >code elsewhere. Probably the same winclip.c file.
>
> Done, it's in winclip.c. There is a single function called win_clip_init.
> I've also used this in the os_win32.c file as well.
>
> >Instead of:
> >
> > #if defined (WIN3264)
> >
> >Please use:
> >
> > #if defined(WIN3264)
> >
> >
> >Perhaps FEAT_CYGWIN_WIN32_CLIPBOARD can be defined automatically when
> >building a non-GUI version with Cygwin?
>
> This is now part of the configuration scripts. I've tested them and
> they detect if compiling upon in the cygwin environment and if you are
> including X11 or GUI. If you are on cygwin and have the X11 packages
> then you need to run configure with: --without-x --enable-gui=no.
>
> >About calling clip_init(FALSE): see the call in os_win32.c. The one in
> >term.c is for xterm. Instead of copying this code with the magic names
> >it should be in a common place. Hmm, it appears it has already been
> >duplicated...
>
> Ok, I'm still a bit confused about when clipboard should be turned on
> or off.
> I don't understand why the clip_board would become unavailable at this
> point in term.c depending if FEAT_MOUSE is active.
>
> However, I DO know that I don't want it turned off when setting the
> termname with this patch, the clipboard is not terminal dependent, but is OS
> dependent in CYGWIN + WIN32 environment.
>
> Attached is a brand new patch for these changes.
Thanks for updating the patch. I'll have another look at it later.
--
"You know, it's at times like this when I'm trapped in a Vogon airlock with
a man from Betelgeuse and about to die of asphyxiation in deep space that I
really wish I'd listened to what my mother told me when I was young!"
"Why, what did she tell you?"
"I don't know, I didn't listen!"
-- Arthur Dent and Ford Prefect in Douglas Adams'
"The Hitchhiker's Guide to the Galaxy"
/// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
