Martin Toft wrote:
> On Sun, Aug 19, 2007 at 09:11:41PM +0200, Bram Moolenaar wrote: > > Good catch with "]". By itself it's not recognized, only the matching > > "[" is. > > > > How about making a bit cleaner: You are overwriting the string and > > restoring the character in four places. If we make a > > vim_isfilec_or_wc() function that could be simplified a lot. You can > > safely assume that a wildcard char is not multi-byte. Thus putting > > the byte in a two-byte buffer and then invoking mch_has_wildcard() > > should be OK. > > Thanks for the feedback. The patch worked but it was kind of messy. It > illustrated quite well that comments starts to appear when the code no > longer speaks for itself. > > I have attached a cleaner patch. Much cleaner, thanks. -- hundred-and-one symptoms of being an internet addict: 209. Your house stinks because you haven't cleaned it in a week. /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ download, build and distribute -- http://www.A-A-P.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
