François Ingelrest wrote:

> On Fri, Mar 28, 2008 at 5:09 PM, François Ingelrest <[EMAIL PROTECTED]> wrote:
> > On Wed, Mar 26, 2008 at 10:15 PM, Bram Moolenaar <[EMAIL PROTECTED]> wrote:
> >  >  François Ingelrest wrote:
> >  >  > I've taken a look at the code and the fix consists in one small change
> >  >  > (see attached patch): setting the height of the current real line to 1
> >  >  > instead of the number of visible lines, so that the menu always
> >  >  > appears under the current visible line. I can't believe such an easy
> >  >  > solution has not been applied before without a good solution, so I'm
> >  >  > pretty sure I must be missing something. Is there someone that could
> >  >  > enlighten me on the subject?
> >  >
> >  >  The idea is that the rest of the line may contain useful text that you
> >  >  want to read when selecting an entry from the popup menu.  Obviously
> >  >  this only works when the line wraps only once or twice.
> >  >
> >  >  Perhaps a good compromise is to use 1 when the number of visible lines
> >  >  is more than 2 or 3.
> >
> >  I was on trip this week and while using Vim I noticed this does not
> >  work: if the word to be completed is not on the first visible line,
> >  the popup menu may appear over it since it is always below the first
> >  visible line.
> >
> >  I understand your argument, but the first time I saw the popup menu
> >  far from the current (visible) line, I did not understand it was below
> >  the real line and thought it was somewhat a bug. I'll try using Vim
> >  with your suggestion, to see if I can get used to it. Thanks!
> 
> Here are two patches I've written. The first one leaves a maximum of
> two lines of context between the cursor and the popup menu. The second
> one introduces an option (pumshift) to set that value (default is
> two).

Thanks.  I don't think this is worth adding another option.  I'll look
into your first patch when I have some time.  In the mean time, opinions
are welcome.

-- 
A bad peace is better than a good war. - Yiddish Proverb

 /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Raspunde prin e-mail lui