Hi! On Fri, May 2, 2008 at 10:23 PM, Bram Moolenaar <[EMAIL PROTECTED]> wrote: > > Here is a patch that improves a bit notebook tabs with GTK2. It: > > - Groups the creation of tab labels into one function (the code was > > duplicated at two places before) > > - Adds a file icon in front of the label > > > > Here are some screenshots: > > > > http://www.silent-blade.org/misc/gvim-notebook-before.png > > http://www.silent-blade.org/misc/gvim-notebook-after.png > > > > Comments are welcome :-) > > I also think that the space that the icon takes is too much. Most > people edit files of the same type (e.g., all Java files), the icon > isn't very helpful then. And when you have two windows in one Tab, what > icon are you going to show?
I would not say it's useless in the sense that icons make notebook tabs a bit nicer to look at. I actually never liked notebook tabs in GVim because they are too narrow and that makes difficult to spot the one I need (the main reason I wrote this small patch). Also, in this perspective, the toolbar is useless as it takes too much space for commands that can already easily be typed. But it's there because it's the GUI version and that's the way GUIs generally look like. The same goes for icons in notebook tabs: Almost all the GUI applications I can think of display such an icon although the label would be sufficient. It's just a bit nicer to look at. Regarding multiple windows in one notebook tab: As Tony said, the active window should be used. Actually the active filetype should be used, and the icon should be updated as soon as it changes, be it because the active window has changed or because the user has :set it. Anyway, if you feel it's useless, I'm fine with that: I'm not going to spend time writing code that people don't want/need. That's also why I wanted your feedback :-) And thanks for taking the time to reply! --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
