On Wed, Nov 5, 2008 at 1:20 PM, Benjamin Fritz <[EMAIL PROTECTED]>wrote:
>
> On Wed, Nov 5, 2008 at 1:18 PM, Frew <[EMAIL PROTECTED]> wrote:
> >>
> >> Two bugs that I've found while using this patch with real perl code:
> >>
> >> 1) Commented-out lines can end a fold region
> >> 2) The closing brace in code like $abc{def} ends fold regions
> >>
> >> Bug 1 is fixed by adding a skip group to the perlSubFold and
> >> perlBlockFold definitions: skip="#.*"
> >> Bug 2 is something I will try to fix later unless someone beats me to
> >> it.
> >>
> >> I have yet to see any feedback or developments on this other than an
> >> "I'll look at it" from the script maintainer. Has anyone tried this?
> >
> > I just found this and patched the file. Maybe I patched it
> > incorrectly (I don't have patch handy atm) but it seems to fold
> > anything with { and }, that is, if I do this:
> >
> > sub foo {
> > $blah->bar($self->{test});
> >
> > more..
> > }
> >
> > just the first two lines get folded.
> >
> > Hope that helps some.
> >
> > -fREW
> >
>
> That does help some, it falls into bug (2) that I listed, which I
> suspect is very common.
>
> Unfortunately, I am very much a beginner at perl, and am not very
> familiar with the syntax, so it may take me a little while. I suspect
> the best way to proceed might be to just make another group that folds
> all {...} blocks that aren't the special cases like if, sub, etc. I'll
> try to get to it sometime this month, unless someone else fixes it
> first of course :-)
>
> >
> So far, so good.
Not to be uber-nitpicky, but what do you folks think about changing all of
the variables that control the script's behavior (ie. perl_include_pod,
perl_fold, etc.) from globals to buffer-locals?
I like to set parameters such as these from from my after/ftplugin/*.vim
files so as to keep my .vimrc neat and trim. Similarly, I think it is
better (at least aesthetically) to not clutter the global namespace with
variables that only apply to particular buffers.
Food for thought,
Erik
--
Erik Falor
Registered Linux User #445632 http://counter.li.org
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
