On Thu, Nov 6, 2008 at 5:14 PM, Bram Moolenaar <[EMAIL PROTECTED]> wrote:
>
> Xavier de Gaye wrote:
>
>> When an application forks a Vim that is not compiled with the
>> netbeans_intg feature, the application waits for Vim to establish the
>> socket connection and Vim silently ignores the "-nb" command line
>> argument. It is difficult for the user to understand what is wrong.
>>
>> The attached patch causes Vim to exit with an error message when it is
>> invoked with "-nb" and not compiled with the netbeans_intg feature.
>> This is already what is happening when the diff feature is missing and
>> vim is invoked as vimdiff.
>
> The idea looks right: using -nb when it's not supported should make Vim
> quit.
>
> The place where you invoke mch_exit() looks a bit weird.  Not sure if
> this is the best solution.  And when compiled without GUI (e.g.,
> starting a small version of Vim) this exit won't be reached.  Would
> someone only use -nb with gvim?
>
> The message should be defined in one place, not twice.

Right of course. I will try sending another patch fixing these points.

BTW do you think an implementation of netbeans over Vim console is
acceptable as a Vim patch (as opposed to an external patch such as
those in http://groups.google.com/group/vim_dev/web/vim-patches).


Xavier

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Raspunde prin e-mail lui