On 21/11/08 20:26, Dominique Pelle wrote:
> Hi
>
> The attached patch fixes a compilation warning in vim-7.2.49:
>
> getchar.c: In function 'makemap':
> getchar.c:4705: warning: format not a string literal and no format arguments
> getchar.c: In function 'put_escstr':
> getchar.c:4804: warning: format not a string literal and no format arguments
>
> This warning is not related to the flag -D_FORTIFY_SOURCE=1 (unlike
> other compilation warnings discussed recently).
>
> -- Dominique
I don't see this warning, compiling with
linux:~ # gcc --version
gcc (SUSE Linux) 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision
135036]
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
linux:~ #
Neither in my huge build, where the gcc command-line is
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng12 -DORBIT2=1 -pthread
-I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0
-I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1
-I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0
-I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0
-I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include
-I/usr/include/orbit-2.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0
-I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2
-I/usr/include/pango-1.0 -I/usr/include/gail-1.0
-I/usr/include/freetype2 -I/usr/include/atk-1.0
-I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/libpng12
-O2 -fno-strength-reduce -Wall -D_FORTIFY_SOURCE=1 -D_REENTRANT
-D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -DDEBUGGING -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64
-I/usr/lib/perl5/5.10.0/i586-linux-thread-multi/CORE
-I/usr/include/python2.5 -pthread -I/usr/include
-D_LARGEFILE64_SOURCE=1 -I/usr/lib/ruby/1.8/i586-linux -o
objects/getchar.o getchar.c
nor in the tiny build, with
gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall
-D_FORTIFY_SOURCE=1 -o objects/getchar.o getchar.c
do I get any compile warnings for that module. I see the fprintf(fd,
...) calls on the two lines where the "before" context of your patch
shows them, and on many other lines too: 4694, 4696, 4703, 4705, 4733,
4735, 4760, 4804, 4818, 4823.
Best regards,
Tony.
--
Most people wouldn't know music if it came up and bit them on the ass.
-- Frank Zappa
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---