Jonathon Mah wrote:
> On 2009-01-12, at 03:29, Nico Weber wrote: > > >> This patch is completely rewritten, with very little in common with > >> the previous one. Again, some review is much needed. I didn't adjust > >> the documentation; is it customary for me to do that, or to have Bram > >> do it? > > > > That's your job. > > OK, once more with feeling. Sincere apologies for the noobness. The patch adds "focusonly" to the 'scrollopt' option by default. That means people who previously did something like ":set scrollopt=ver" will get different behavior. I think we can avoid that. Isn't there another name to use, so that we can leave the default value as it was? Perhaps "always" or "unfocused". You removed the use of old_topline and old_topfill. How can you guarantee that without the new flag things work just like before? You change "curwin" without changing "curbuf", that probably won't work properly. You add a call to do_check_scrollbind() in edit.c without checking that it's not the current window that is being scrolled. Same in normal.c. Looks like this patch needs a bit more work! -- Don't read everything you believe. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ download, build and distribute -- http://www.A-A-P.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
