Dominique Pelle wrote:
> > But the patch breaks something. =A0See the 2 screenshots > > before & after patch (gvim-7.2.102 with/without patch): > > > > http://dominique.pelle.free.fr/pic/visual-sel-before-patch.png > > http://dominique.pelle.free.fr/pic/visual-sel-after-patch.png > > > > After patch, the column in the visual selection where cursor > > is located has the highlight of visual selection instead of > > CursorColumn (good). =A0However, notice that with the > > patch, the cursorcolumn is no longer completely highlighted > > outside the visual selection which is not right (before patch > > was better in that regard). With patch, the cursor line becomes > > only =A0highlighted beyond the end of lines (not good). > > > This new attached patch fixes the problem but I described > with the original patch (patch broke highlighting of cuc outside > visual selection). > > See new screenshot with latest patch: > > http://dominique.pelle.free.fr/pic/visual-sel-after-new-patch.png > > That looks better to me: notice on screenshot that cursor's > column is now properly highlighted outside the visual selection > (using CursorColumn highlight group) and inside the visual > selection the visual selection using Visual highlight group. Thanks. I think it's a matter of what confuses you. Another optimization may be to let the Visual highlighting overrule the 'cursorcolumn' only for Block mode. For linewise and character selection, especially when selecting a larger area of text, the cursorcolumn can remain visible without much confusion. > Now remains the question. Why the inconsistency: visual > selection disables the cursorline highlighting? Should this > also be fixed? The 'cursorline' highlighting is always confusing, no matter what kind of Visual selection you are doing. Unles perhaps you have set the color to be hardly noticable. -- hundred-and-one symptoms of being an internet addict: 57. You begin to wonder how on earth your service provider is allowed to call 200 hours per month "unlimited." /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ download, build and distribute -- http://www.A-A-P.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// --~--~---------~--~----~------------~-------~--~----~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~----------~----~----~----~------~----~------~--~---
