24-03-2009 Andreas Bernauer <[email protected]>:
>
> Seems to work.
> Passes all tests.
All suggestions I do not relate to have been taken into account.
> * I also want to point out that the patch changes the semantics of buf_spname
> in
> src/buffer.c: buf_spname now returns an allocated string, which has to be
> freed by the caller. The patch takes care that all (other) calls to
> buf_spname
> free the returned string, but other patches might not be aware of this
> change,
> or this change might be considered as an unwanted side effect.
Agreed. Will wait for Bram's decision regarding this issue.
> Remarks for improvement:
> * :[l]grepadd adds new matches to the location/error list. Should the title
> show this? Ditto for caddfile, etc.
My feeling is that the original command is the more important one. This
is why I chose to keep its title and decided to ignore the .*add.*
commands. This was also the reason for introducing the :csettitle and
:lsettitle commands.
> * The generated quickfix title seems to be saved somewhere. Is it difficult to
> add :csettitle! and :lsettitle! which switch back to the generated/default
> name?
You mean to revert the effect of :csettitle "blah blah blah" you execute
:csettitle! ?
If so - done.
> * When the error list is loaded with 'cfile /tmp/errors', could the title just
> say '/tmp/errors' or ':cfile /tmp/errors'. This would give a visual hint
> that the error list was loaded with a vim command and not by a program
> called
> 'cfile'. Ditto for 'lfile', 'cgetfile', 'lgetfile'.
I'd say either all commands or none. Currently implemented it for all
commands that can produce an error list.
> * Loading the error list from a buffer with 'cbuffer' just mentions the buffer
> number ("cbuffer 24"), which is not very helpful. Could the title also
> display the buffer name?
Done. Right now the buffer's name is appended inside parentheses to the
command name.
Thank you for a scrupulous review!
--
Cheers,
Lech
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
