Nico Weber wrote:
> On 22.05.2009, at 11:20, Bram Moolenaar wrote:
>
> > Here is a new patch that hopefully fixes both the crash and the leaks.
> > It's a bit tricky, but I think this catches all situations.
> > Please verify.
> >
> > Note that with your script one needs to wait a few moments before
> > exiting to give the garbage collector a chance.
>
> LGTM. Thanks for taking a look at this.
>
> I ran the offending script with and without this patch under valgrind,
> the patch seems to remove the double free without introducing a memory
> leak. Should there be a testcase for this in the test files?
There should be. Care to write one?
> Nit: garbage_collect() now contains a single step labeled "1." --
> perhaps get rid of the number?
I already sent out the patch. I'll adjust the comments and send it out
later.
--
ARTHUR: Be quiet! I order you to shut up.
OLD WOMAN: Order, eh -- who does he think he is?
ARTHUR: I am your king!
OLD WOMAN: Well, I didn't vote for you.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
