Petr Splichal wrote:
> Recently I've noticed that the Vim's "make test" does not return
> appropriate exit code if something goes wrong during the testing.
>
> This makes the usual sequence "make && make test && make install"
> unusable. Including such a test inside a source package makes no
> sense and actually does not prevent any possible failures which
> should be it's main purpose I guess.
>
> The following comment from the Makefile is not true, as the "ALL
> DONE" message appears always, regardless of the actual test result:
> # If everything is alright, the final message will be "ALL DONE".
>
> Moreover, the final result output of the test seems quite brief to
> myself. From the report it's not clear which/how many tests were
> actually run:
>
> Test results:
> ALL DONE
>
> I've created a simple patch that fixes all the issues mentioned.
> What do you think about it? Thank you for your time! And special
> thanks to Bram for the Vim itself! It's really a great tool! :-)
>
> psss...
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> FAIL before:
>
> # make test
> ...
> test3 FAILED
> ALL DONE
> # echo $?
> 0
>
> FAIL after:
>
> # make test
> ...
> Test results:
> test1 PASS
> test2 PASS
> test3 FAILED
> test4 PASS
> test5 PASS
> test6 PASS
> ...
> SOME TESTS FAILED
> make: *** [nongui] Error 1
> # echo $?
> 2
Looks good to me. Objections anyone?
--
Engineers are widely recognized as superior marriage material: intelligent,
dependable, employed, honest, and handy around the house.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
