On Wed, Jan 20, 2010 at 9:33 AM, Patrick Texier <[email protected]> wrote: > Le Tue, 19 Jan 2010 23:34:22 +0100, Bram Moolenaar a écrit dans le > message <[email protected]> : > >> Patch 7.2.343 (after 7.2.338) >> Problem: Can't compile on Win32. >> Solution: Insert the missing '|'. >> Files: src/ex_cmds2.c > > New problem: Can't compile on Linux using GCC 3.2 > > gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -I/usr/include/gtk-1.2 > -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include > -g -O2 -fno-strength-reduce -I/usr/X11R6/include -D_REENTRANT > -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 > -I/usr/include/gdbm -I/usr/lib/perl5/5.8.0/i386-linux-thread-multi/CORE > -I/usr/include/python2.2 -pthread -I/usr/include -o > objects/ex_cmds2.o ex_cmds2.c > ex_cmds2.c:2818:1: directives may not be used inside a macro argument > ex_cmds2.c:2817:37: unterminated argument list invoking macro "mch_open" > ex_cmds2.c: In function `fopen_noinh_readbin': > ex_cmds2.c:2821: `mch_open' undeclared (first use in this function) > ex_cmds2.c:2821: (Each undeclared identifier is reported only once > ex_cmds2.c:2821: for each function it appears in.) > ex_cmds2.c:2821: parse error before numeric constant > make[1]: *** [objects/ex_cmds2.o] Erreur 1 > make[1]: Quitte le répertoire `/home/pt/dev/stable/vim72/src' > make: *** [first] Erreur 2
Thanks for catching that. It's easy to forget that mch_open is a macro. :) GCC 4.1 onward added an extension which supports directives inside macros, which explains why I didn't encounter this when I submitted the FD_CLOEXEC patch to Bram. Your patch works well here, too. -- James GPG Key: 1024D/61326D40 2003-09-02 James Vega <[email protected]>
-- You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php
