Xavier de Gaye wrote: > On Thu, Feb 11, 2010 at 8:55 PM, Bram Moolenaar wrote: > > > > You move the code to connect for different GUI versions to another > > place, away from the disconnect code. I don't see a reason for this. > > Why not keep it as it was? > > > > > Hi Bram, > > netbeans_startup_done() has been split in two parts: > * netbeans_connect() > * a new function called netbeans_gui_register() > > This is needed so that when the user is running netbeans in a vim > console, then netbeans is still available after the ":gui" command > is run and vim switches to the gui interface (requiring only a call > to netbeans_gui_register(), the socket being already connected). > > I have put the code of netbeans_gui_register() close to > netbeans_startup_done() because they are related. But > netbeans_gui_register() can be moved up close to the disconnect code.
I find it most important to keep the code for a specific GUI together, if it's not too much hassle. So we have a block of code that's the GUI-specific implementation of the netbeans interface. If one would add another GUI most of the change would be to add another block here, instead of making changes all over the place. -- A computer without Windows is like a fish without a bicycle. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ download, build and distribute -- http://www.A-A-P.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php
