On 18/05/10 09:55, Tony Mechelynck wrote:
[...]
/usr/include/stdint.h:31|#ifndef __uint32_t_defined
/usr/include/stdint.h:32|typedef unsigned int uint32_t;
/usr/include/stdint.h:33|# define __uint32_t_defined

these are of course lines 51 to 53




Looks like the new encryption subsystem should have obeyed :help
style-names, as follows:

<quote>
Typedef'ed names should end in "_T": >
typedef int some_T;
</quote>


Best regards,
Tony.

Sorry: if it's a Vim typedef it should end in _T

        typedef unsigned int uint32_T

if it's a define (which, on re-reading, seems more likely) it should be in all caps

        #define UINT32 unsigned int

or else (probably recommended IIUC) <stdint.h> should have been included before the point where the new code defines its 32-bit uint type.

Maybe add a configure check for how to define a "Vim unsigned 32-bit integer", and whether to add an #include <stdint.h> if other compilers do it otherwise?


Best regards,
Tony.
--
WOMAN:   King of the who?
ARTHUR:  The Britons.
WOMAN:   Who are the Britons?
ARTHUR:  Well, we all are. we're all Britons and I am your king.
The Quest for the Holy Grail (Monty Python)

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

Raspunde prin e-mail lui