Lech Lorens wrote: > On 17-Jul-2010 Bram Moolenaar <b...@moolenaar.net> wrote: > > > > Lech Lorens wrote (more than a year ago): > > > > > On 28-Mar-2009 Lech Lorens <lech.lor...@gmail.com> wrote: > > > > Improved version of patch is attached. I took into consideration most of > > > > the suggestions. I will be grateful for any more comments. > > > > > > I found an invalid memory access while executing the :tabs command. The > > > attached patch fixes the problem. > > > > I finally took some time to look at this patch. Unfortunately > > documentation is missing, I think it must be elsewhere. Would be a lot > > simpler to have it as one patch. > > At that time the runtime files were not under version control like the > source code was. That is why I split the patch into two files. Sorry for > the inconvenience. > > > Adding two commands to set the title is a bit too specific. Why not put > > the values in window-local variables? Then these can be set from any > > script that generates a quickfix or location list. The ":make" and > > ":grep" commands can also do this. Advantage is that the values are > > available to a custom status line as well. But perhaps there is a > > disadvantage as well? > > I like your idea very much, makes the whole mechanism much more > flexible. Modifying Vim to use w:quickfix_title variable for specifying > what is displayed in the status bar of a quickfix window proved to be > easy. I need some more time to clean up the code, though. I'll do it on > Thursday. > > I can't see any disadvantages of this approach. However, one thing that > becomes obvious at this point, is that unless it can be done with > a clever trick that I can't think of right now (using the value of &bt, > but then what?), there is no way to make a custom status line display > "Quickfix List" or "Location List", much less their localised versions.
It would be possible to add a statusline item for this, like %h. > > There is quite a bit of repeated code. E.g., buf_spname() is often > > called to fill a buffer. Can easily make a separate function for this. > > You mean I should prepare a function which will copy the value returned > by buf_spname() to e.g. IObuffer and free the allocated memory? Sounds > like a good idea. > > Thanks for the enormous amount of work you had to put into Vim recently! Note that I'm including less changes now, and nothing that looks "dangerous" or needs to be discussed first. -- My girlfriend told me I should be more affectionate. So I got TWO girlfriends. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ download, build and distribute -- http://www.A-A-P.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
