On 21 July 2010 21:36, Bram Moolenaar wrote: > > Björn wrote: >> >> Bram: could you indicate if there is any chance this is making it for >> 7.3 (or at all)? It seems this feature would mostly be used by Mac >> users (since "all" Macs have horizontal scrolling abilities) and a few >> users have asked for this feature. If you'd rather hold off merging >> this patch I'll merge it with the MacVim source code so that it gets >> tested properly and then you can take a look at it later. > > It looks fairly good. It's a bit big to include at the last moment, > but we still have some time for testing. > > Can you change the argument for the direction to use an enum or #defined > value? Using 0, 1, -1 and -2 is a bit confusing.
Agreed. I did this since I wasn't sure where to add the #define's. They are at the end of vim.h now, hope that makes sense (it seemed standard to use a shortened version of the function where the #define is used as a prefix so I called them MSCR_*). > > For style, instead of: > > if (val < 0) val = 0; > > use: > > if (val < 0) > val = 0; > > gui_find_longest_lnum() is missing a prototype. Ok, I have addressed these two issues as well. The attached patch should be applied after the other three. I sent it as a separate patch instead of merging it with the others to make it easier to see what changes I made this time around. Björn -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
0001-Address-Bram-s-comments.patch
Description: Binary data
