Bram Moolenaar wrote:

> Patch 7.3.152
> Problem:    Xxd does not check for errors from library functions.
> Solution:   Add error checks. (Florian Zumbiehl)
> Files:      src/xxd/xxd.c

Hi

Patch 7.3.152 introduces a compilation warning with gcc:

xxd.c:691: warning: suggest explicit braces to avoid ambiguous ‘else’

Attached trivial patch fixes it.

Regards
-- Dominique

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
diff -r 6e042e124c4e src/xxd/xxd.c
--- a/src/xxd/xxd.c	Fri Apr 01 19:14:40 2011 +0200
+++ b/src/xxd/xxd.c	Fri Apr 01 19:51:06 2011 +0200
@@ -689,6 +689,7 @@
 
 	  while (s--)
 	    if (getc(fp) == EOF)
+	    {
 	      if (ferror(fp))
 		{
 		  die(2);
@@ -698,6 +699,7 @@
 		  fprintf(stderr, "%s: sorry cannot seek.\n", pname);
 		  return 4;
 		}
+	    }
 	}
     }
 

Raspunde prin e-mail lui