Gasper Azman wrote:
> (Note: I can't post to this list yet, a mod has to approve this email.
> I'm also sorry for the gmail chat invites gmail spammed in my name, an
> unlucky misclick caused that and I didn't know how to stop it. I also
> sent this patch yesterday already, but it seems every one of the mods
> failed to post it to the list, so I'm sending it again in hope of it
> getting through this time.)
>
> Hi everyone,
>
> I also stumbled upon a segfault on autocompletion. I proceeded to find
> a bug in the latest hg source in edit.c that I think causes the crash
> - code forgets to check whether the leader pointer is null.
>
> This is what fixes the issue for me:
>
> ####################################
> diff -r d6c709d07173 src/edit.c
> --- a/src/edit.c Fri Sep 02 14:18:20 2011 +0200
> +++ b/src/edit.c Tue Sep 06 15:22:02 2011 +0200
> @@ -4604,7 +4604,7 @@
> {
> if (!compl_get_longest || compl_used_match)
> ins_compl_insert();
> - else
> + else if(compl_leader != NULL)
> ins_bytes(compl_leader + ins_compl_len());
> }
> else
> ####################################
I think patch 7.3.294, which reverts 7.3.289, already fixed this.
How did you reproduce this crash? It might be useful to add a test.
--
The acknowledged parents of reengineering are Michael Hammer and James Champy.
When I say they're the "parents" I don't mean they had sex - and I apologize
for making you think about it. I mean they wrote the best-selling business
book _Reengineering the Corporation_, which was published in 1993.
Businesses flocked to reengineering like frat boys to a drunken
cheerleader. (This analogy wasn't necessary, but I'm trying to get my mind
off that Hammer and Champy thing.)
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
