On Wed, Jan 25, 2012 at 9:19 AM, Csaba Hoch <[email protected]> wrote: > About the indent file: The indent file in vimerl is the improved > version of the indent file currently in Vim (written by me), so that > will be easy to merge. I will check that the changes have no bad > effects and afterwards I will send the new version to this mailing > list.
At this moment I'm finishing a completely new indent script written partially in Erlang[1] which should be better than the pure Vim version[2] derived from Csaba. Maybe my minor improvements to the Csaba's indent script doesn't worth it. Furthermore, the issue that remains open[3] it is not fixed in my version (and I think it also exists in the Csaba's version). So, I'm probably dropping the pure Vim indent and taking the new one in Erlang for Vimerl. This Erlang indenter isn't gonna be included in the official Vim distribution, so that Csaba should keep his version if he can mantain it. As it seems a good default one for Vim. [1] https://github.com/jimenezrick/vimerl/tree/erlang-indenter/indent [2] https://github.com/jimenezrick/vimerl/blob/master/indent/erlang.vim [3] https://github.com/jimenezrick/vimerl/issues/7 > About the syntax file: The syntax file in vimerl was written by Oscar > Hellström from scratch AFAIK, so it is quite different from the syntax > file currently in Vim (written originally by Kresimir Marzic and is > now maintained by me). I would advise against replacing the syntax > file, because changing the Erlang syntax highlight drastically would > be a negative user experience. The two files could be compared though > and the current Vim version could be improved by ideas from the other. I have the impression (maybe wrong) that the syntax file from Oscar is more complete, but it's your call Csaba :-) > About the ftplugin file: Currently Vim has no ftplugin file for > Erlang. The ftplugin file of vimerl sets some options, but it contains > mostly folding code. I think it can be added to Vim, but not > unchanged. I have two suggestions: > > 1. Don't turn on folding on by default. The plugin does that now, but > this should not be done by any ftplugin shipped with Vim. I think > the best solution would be to set foldexpr but not to set foldmethod. > This way the user will be able to turn it on with a simple > "set foldmethod=expr" command. The variable `g:erlang_folding' controls if the specific folding for Erlang is enabled. I did this because it's what I saw in most of the plugins distributed with Vim. I'm fine with any solution as long as it is the most standard one. Also I recently removed a lot of code from folding to keep as simple as possible[4]. [4] https://github.com/jimenezrick/vimerl/blob/master/ftplugin/erlang.vim > 2. Remove this line: > > setlocal omnifunc=erlang_complete#Complete" > > If we don't add autoload/erlang_complete.vim, which actually implements this > function, this function should not be used. OK, but maybe this could be automatically set at runtime. Detecting if erlang_complete.vim exists or something like that... To sum up: - Keep Csaba indent file, as I don´t plan to maintain my pure Vim version (or Csaba merge my changes, but maybe not worth it...). - Decide which syntax file to keep. - Update the ftplugin. Regards -- Ricardo -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
