> For consistency we need to mention the second argument as optional. I
> think it's fine, the user will want to read the detailed explanation
> anyway.
> 
> For the code: It duplicates very similar code in three places. Can you
> make this a function that accepts an argument that specifies the 
operation?
> 
> It would also be better to compute the result in a local variable and
> assign it to rettv->vval.v_number at the end.

Thanks for your replies.

https://gist.github.com/1767460
https://raw.github.com/gist/1767460/gistfile1.diff 

Done.

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

Raspunde prin e-mail lui